Implement global package search for build chroot results#4154
Implement global package search for build chroot results#4154sundaram123krishnan wants to merge 1 commit intofedora-copr:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a global package search feature, which is a valuable addition. The implementation is well-structured, including a new form, view, logic, template, and tests. I've identified a couple of areas for improvement in the view logic and form validation that would enhance maintainability and performance. My suggestions focus on refactoring repetitive code and optimizing a database query.
| has_value = any([ | ||
| self.name.data, | ||
| self.version.data, | ||
| self.release.data, | ||
| self.arch.data, | ||
| self.epoch.data is not None, | ||
| ]) | ||
| if not has_value: | ||
| self.name.errors.append("At least one search field must be provided") | ||
| return False |
There was a problem hiding this comment.
The logic to check if at least one field has a value is duplicated here and in the search_params method. You can simplify this by calling self.search_params() and checking if the resulting dictionary is empty. This avoids code duplication and makes the validation more maintainable.
if not self.search_params():
self.name.errors.append("At least one search field must be provided")
return False
sundaram123krishnan
force-pushed
the
package-search-form
branch
2 times, most recently
from
30faadf to
65d3c33
Compare
sundaram123krishnan
force-pushed
the
package-search-form
branch
from
65d3c33 to
4c73317
Compare
1 participant
Fixes #1947